Fix errors in conditions for activating vizAugmenter
#5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
seanneumann,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
fix-viz-aug-error-2
branch
from
b02e48a
to
180cf69
Compare
Codecov Report
@@ Coverage Diff @@
## main #5213 +/- ##
==========================================
- Coverage 66.76% 66.76% -0.01%
==========================================
Files 3278 3278
Lines 62999 63008 +9
Branches 10031 10034 +3
==========================================
+ Hits 42059 42065 +6
- Misses 18473 18474 +1
- Partials 2467 2469 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kavilla
approved these changes
Oct 4, 2023
lezzago
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Miki <[email protected]> (cherry picked from commit 7207635) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Miki <[email protected]> (cherry picked from commit 7207635) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
…oject#5213) Signed-off-by: Miki <[email protected]> Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
…oject#5213) Signed-off-by: Miki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isEligibleForVisLayersincorrectly made assumptions about types of parameters it was provided; this change adds guards against them.Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr