Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update index random function to fix the bogus document deletion #11142

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

neetikasinghal
Copy link
Contributor

@neetikasinghal neetikasinghal commented Nov 8, 2023

Description

This change updates the index random function to delete the bogus documents and add a refresh in the function such that the bogus documents are deleted and refresh ensures that the search doesnt account for the deleted segments.
This should fix some flaky issues encountered after adding the indexRadomForConcurrentSearch function to the tests.

Also, added TransportTwoNodesSearchIT.java to use indexRandomForConcurrentSearch.

Related Issues

Resolves #10900

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@neetikasinghal
Copy link
Contributor Author

@reta @andrross @jed326 please review the changes.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Compatibility status:

Checks if related components are compatible with change bab175a

Incompatible components

Incompatible components: [https:/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security-analytics.git, https:/opensearch-project/security.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/index-management.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/sql.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/notifications.git, https:/opensearch-project/observability.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/alerting.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/reporting.git]

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.test.rest.ClientYamlTestSuiteIT.test {p0=search/160_exists_query/Test exists query on mapped byte field}
      1 org.opensearch.test.rest.ClientYamlTestSuiteIT.classMethod
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search/160_exists_query/Test exists query on mapped byte field}
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_mapping/10_basic/Get /_mapping}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.classMethod

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #11142 (bab175a) into main (0d54c16) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #11142      +/-   ##
============================================
- Coverage     71.19%   71.15%   -0.04%     
+ Complexity    58816    58761      -55     
============================================
  Files          4883     4883              
  Lines        277144   277144              
  Branches      40281    40281              
============================================
- Hits         197310   197202     -108     
- Misses        63425    63465      +40     
- Partials      16409    16477      +68     

see 480 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

#3603 - flaky test
#10193 - flay test
#10006 - flaky test
#9332 - flaky test

@neetikasinghal
Copy link
Contributor Author

neetikasinghal commented Nov 10, 2023

@andrross / @reta can you please help merge the pr? there are other prs pending to be raised that are dependent on this.

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

#10231 - flaky
#9499 - flaky

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 2bd709b into opensearch-project:main Nov 10, 2023
29 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2023
)

Signed-off-by: Neetika Singhal <[email protected]>
(cherry picked from commit 2bd709b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
neetikasinghal pushed a commit to neetikasinghal/OpenSearch that referenced this pull request Nov 13, 2023
…nsearch-project#11142)

Signed-off-by: Neetika Singhal <[email protected]>
(cherry picked from commit 2bd709b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Neetika Singhal <[email protected]>
andrross pushed a commit that referenced this pull request Nov 13, 2023
) (#11161)

(cherry picked from commit 2bd709b)

Signed-off-by: Neetika Singhal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
3 participants