Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le architecture #3435

Closed
wants to merge 1 commit into from

Conversation

helix-loop
Copy link

@helix-loop helix-loop commented May 24, 2022

Add ppc64le architecture for the current architecture check.

Description

Ability to build OpenSearch on ppc64le architecture

Issues Resolved

#1303

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 61cff75e69b9aa11786beaafd52df8e74a057643
Log 5569

Reports 5569

@dblock
Copy link
Member

dblock commented May 24, 2022

@helix-loop Thanks! The PR needs git commit --amend -s to get DCO to pass.

In the meantime, do we need both ppc64 and ppc64le? And what hardware did you test this on?

@helix-loop
Copy link
Author

@dblock It would be better to have both, but I can only test and tested this on ppc64le.

Add ppc64le architecture fot the current architecture check.

Signed-off-by: Fabian Ruf <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success dcfb53a
Log 5642

Reports 5642

@dblock
Copy link
Member

dblock commented Jun 13, 2022

Is this ready? Unit tests?

@kartg
Copy link
Member

kartg commented Aug 4, 2022

@helix-loop are you still working on this? What is left to get this from draft to ready-to-merge?

@helix-loop
Copy link
Author

Currently not. I guess the Unit tests are missing to get this ready. However #3930 seems to be further.

@dreamer-89
Copy link
Member

@helix-loop : Are you still working on this ?

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 5, 2023

@helix-loop Thank you for your contribution! I'm afraid that I have to close this PR.
As mentioned in issue #1303, the code change is made by commit d76adf3

@tlfeng tlfeng closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants