Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ppc64, ppc64le and riscv64 architectures #3930

Closed
wants to merge 3 commits into from

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jul 17, 2022

Signed-off-by: Daniel Widdis [email protected]

Description

Properly parses the Architecture enum when building for ppc64, ppc64le, and RISC-V 64 architectures.

Issues Resolved

Fixes #1303. Fixes #2341. Supersedes PR #3435.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis requested review from a team and reta as code owners July 17, 2022 00:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Daniel Widdis <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #3930 (33d4253) into main (e724b2e) will increase coverage by 0.04%.
The diff coverage is 50.98%.

@@             Coverage Diff              @@
##               main    #3930      +/-   ##
============================================
+ Coverage     70.46%   70.50%   +0.04%     
- Complexity    56600    56628      +28     
============================================
  Files          4557     4563       +6     
  Lines        272737   272755      +18     
  Branches      40040    40040              
============================================
+ Hits         192188   192310     +122     
+ Misses        64324    64233      -91     
+ Partials      16225    16212      -13     
Impacted Files Coverage Δ
.../main/java/org/opensearch/gradle/Architecture.java 100.00% <ø> (+37.50%) ⬆️
...n/cluster/health/TransportClusterHealthAction.java 47.75% <ø> (ø)
...g/opensearch/cluster/ClusterStateTaskListener.java 100.00% <ø> (ø)
.../opensearch/cluster/MasterNodeChangePredicate.java 0.00% <0.00%> (ø)
...ava/org/opensearch/cluster/NotMasterException.java 0.00% <0.00%> (ø)
...rch/cluster/coordination/NoMasterBlockService.java 0.00% <0.00%> (ø)
...ter/coordination/UnsafeBootstrapMasterCommand.java 0.00% <0.00%> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...rch/common/settings/ConsistentSettingsService.java 67.85% <ø> (ø)
.../opensearch/common/util/concurrent/BaseFuture.java 62.71% <0.00%> (ø)
... and 492 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e96a87...33d4253. Read the comment docs.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dbwiddis dbwiddis marked this pull request as draft July 17, 2022 03:07
@dbwiddis
Copy link
Member Author

Converting this to a draft to discuss the appropriate handling of these architectures in the Architecture enum.

I initially submitted this based on the fact that OpenSearch could be built by mapping these distributions to X64. However, looking further at where this enum is used, it seems to impact:

  • whether or not we create a distribution (in this case we do NOT want the X64 enum; we could map to a new enum value)
  • determining the name of the distribution (I don't think any of this code is called if we're not creating a distribution)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dbwiddis
Copy link
Member Author

dbwiddis commented Nov 7, 2022

Closing this as it's completely insufficient. A proper solution may be similar to #4000.

@dbwiddis dbwiddis closed this Nov 7, 2022
@dbwiddis dbwiddis deleted the x64 branch November 7, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RISC-V 64 Support Add support for ppc64le
2 participants