Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] check if NVM_DIR exists #1925

Closed
kavilla opened this issue Apr 7, 2022 · 4 comments
Closed

[Build] check if NVM_DIR exists #1925

kavilla opened this issue Apr 7, 2022 · 4 comments
Assignees
@peterzhuamazon
Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.

Comments

@kavilla
Copy link
Member

kavilla commented Apr 7, 2022 •
edited by peterzhuamazon
Loading

Is your feature request related to a problem? Please describe

Origin: #1905

NVM_DIR might not be defined while building OSD.

Describe the solution you'd like

check if NVM_DIR exists before trying to use it. If not out put an explicit error message

@peterzhuamazon note: This is explicitly related to the OSD and OSD plugins build.sh that requires use of nvm to switch nodejs versions.

Describe alternatives you've considered

#1922

Additional context

No response
@kavilla kavilla added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Apr 7, 2022
@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Apr 12, 2022
@bbarani
Copy link
Member

bbarani commented Jun 6, 2022

@kavilla Are you actively looking in to this issue?

@kavilla kavilla added the good first issue Good for newcomers label Jun 10, 2022
@kavilla
Copy link
Member Author

kavilla commented Jun 10, 2022

I am not. Apologies. But I added a good first issue label to this. This will be an improvement and relatively small but is not a blocker for anything.

@acharyasourav
Copy link

Hey @kavilla I would like to try to fix this issue. Do you have any idea on where I should start looking ?

@bbarani bbarani added the hacktoberfest Global event that encourages people to contribute to open-source. label Oct 5, 2022
@bbarani
Copy link
Member

bbarani commented Mar 13, 2023

According to @peterzhuamazon, this is not an issue anymore so closing it. Feel free to re-open if needed.

@bbarani bbarani closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterzhuamazon peterzhuamazon

Labels
enhancement New Enhancement good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kavilla @peterzhuamazon @bbarani @acharyasourav @zelinh