[OSD][Build] nvm use

[kavilla]

Description

Within OSD we have a .nvmrc file that is used when nvm use
is executing. So we can use the right node version for the
build.

Issue:
n/a

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

n/a

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1905 (bb6daa2) into main (0f02c6f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1905   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02c6f...bb6daa2. Read the comment docs.

[kavilla]

Jenkins is doing stuff that is preventing us from passing the environment variable and running the command that was added https://issues.jenkins.io/browse/JENKINS-51307. Therefore the current node version is being used and having some failures while building 2.0.0.

This also doesn't work because nvm isn't available but I think we need to add nvm to the PATH and have the docker image published so that it can be used here: https:/opensearch-project/opensearch-build/blob/main/docker/ci/dockerfiles/build.centos7.opensearch-dashboards.x64.arm64.dockerfile#L151

[peterzhuamazon]

Jenkins is doing stuff that is preventing us from passing the environment variable and running the command that was added https://issues.jenkins.io/browse/JENKINS-51307. Therefore the current node version is being used and having some failures while building 2.0.0.

This also doesn't work because nvm isn't available but I think we need to add nvm to the PATH and have the docker image published so that it can be used here: https:/opensearch-project/opensearch-build/blob/main/docker/ci/dockerfiles/build.centos7.opensearch-dashboards.x64.arm64.dockerfile#L151

This does work if you can source the nvm.sh before running nvm.

source $NVM_DIR/nvm.sh

[kavilla]

Jenkins is doing stuff that is preventing us from passing the environment variable and running the command that was added https://issues.jenkins.io/browse/JENKINS-51307. Therefore the current node version is being used and having some failures while building 2.0.0.
This also doesn't work because nvm isn't available but I think we need to add nvm to the PATH and have the docker image published so that it can be used here: https:/opensearch-project/opensearch-build/blob/main/docker/ci/dockerfiles/build.centos7.opensearch-dashboards.x64.arm64.dockerfile#L151

This does work if you can source the nvm.sh before running nvm.

source $NVM_DIR/nvm.sh

I understand the NVM docs call out to define $NVM_DIR when setting it up but I'm not seeing the preference to source a script from an environment variable that may not exist rather than adding it to the PATH for the docker image. Would seem like an anti pattern for the repo as well.

[kavilla]

If I source $NVM_DIR will make sure to update https:/opensearch-project/opensearch-build/blob/main/DEVELOPER_GUIDE.md#nvm-and-node to ensure users define it in the environment.

[kavilla]

The builds for 2.0.0 have been broken for a couple days now so to unblock this I have created a follow up issue: #1922 since I still believe adding to PATH fits into this repo more.

[peternied]

Add a check if $NVM_DIR isn't defined then send them to the setup guide - this would be a good fast follow

[kavilla]

Oh yes that would actually be a really good solution that will make me feel better about this code being in here. I've created an issue #1922 but trying my best not to be online so I might not be able to get this as a fast follow.