Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings #134

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Remove warnings #134

merged 1 commit into from
Sep 13, 2022

Conversation

lucasfsvilela
Copy link
Contributor

@lucasfsvilela lucasfsvilela commented Sep 13, 2022

Minor changes for warnings removal.

NamedWriteableRegistryAPI
remove unused local variables
remove unused imports

SDKClient
remove unused private attribute
remove unsed imports

TransportActions
add missing diamond operators

TestNamedWriteableRegistryAPI
remove unused constructor

There are still missing generic declaration on Class<> attributes and variables, which cannot be fixed only through sdk project, as they are used as method parameters from classes that do not belong to sdk project and would require changes on these classes as well.

Signed-off-by: Lucas Faria e Souza Vilela [email protected]

Description

This change remove warnings from code without affecting any functionality.

Issues Resolved

Fixes portions of #130

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Minor changes for warnings removal.

NamedWriteableRegistryAPI
  remove unused local variables
  remove unused imports

SDKClient
  remove unused private attribute
  remove unsed imports

TransportActions
  add missing diamond operators

TestNamedWriteableRegistryAPI
  remove unused constructor

There are still missing generic declaration on Class<> attributes and
variables, which cannot be fixed only through sdk project, as they are
used as method parameters from classes that do not belong to sdk project
and would require changes on these classes as well.

fix #130

Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>
@lucasfsvilela lucasfsvilela requested a review from a team September 13, 2022 14:04
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @lucasfsvilela !

You're right that fixing the Class generics requires updating code on the main OpenSearch project. If you'd like to tackle that in another PR you can submit two PRs: one here and one to OpenSearch linking to the feature/extensions branch there.

@owaiskazi19 owaiskazi19 merged commit 09ce2fc into opensearch-project:main Sep 13, 2022
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
Minor changes for warnings removal.

NamedWriteableRegistryAPI
  remove unused local variables
  remove unused imports

SDKClient
  remove unused private attribute
  remove unsed imports

TransportActions
  add missing diamond operators

TestNamedWriteableRegistryAPI
  remove unused constructor

There are still missing generic declaration on Class<> attributes and
variables, which cannot be fixed only through sdk project, as they are
used as method parameters from classes that do not belong to sdk project
and would require changes on these classes as well.

fix opensearch-project#130

Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>

Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants