-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up compiler warnings #130
Comments
FYI, just noticed this in gradle check logs:
I believe that fixing this issue will resolve this warning. |
Can we use |
Hey @mloufra! SuppressWarnings is used to ignore the warnings. We don't have to ignore them but to resolve them. We need to add a type argument by making the change in OpenSearch repo's |
As a follow-up, there are cases in |
Minor changes for warnings removal. NamedWriteableRegistryAPI remove unused local variables remove unused imports SDKClient remove unused private attribute remove unsed imports TransportActions add missing diamond operators TestNamedWriteableRegistryAPI remove unused constructor There are still missing generic declaration on Class<> attributes and variables, which cannot be fixed only through sdk project, as they are used as method parameters from classes that do not belong to sdk project and would require changes on these classes as well. fix opensearch-project#130 Signed-off-by: Lucas Faria e Souza Vilela <[email protected]> Signed-off-by: Lucas Faria e Souza Vilela <[email protected]>
Some code on⚠️ s in my IDE.
main
is producing compiler warnings and should be cleaned up so I don't see so manyClass
on line 29 needs type arguments. (Class<? extends TransportAction<? extends ActionRequest, ? extends ActionResponse>>>
). This will need a simultaneous change to OpenSearch projectfeature/extensions
branchRegisterTransportActionsRequest
constructor (and associated instance variable).HashMap
on line 38 needs a diamond operator (<>
)Class
(probably<? extends NamedWritable>
). This will need a simultaneous change to OpenSearch projectfeature/extensions
branchNamedWriteable RegistryParseRequest
to change the type ofcategoryClass
to add the same generics.logger
. Either log something or remove it.Example(String message)
. I suspect this means there's missing tests somewhere.extensionsRunner
inNettyTransport
(probably the result of a merge conflict resolution)The text was updated successfully, but these errors were encountered: