Reduce log level for informative message

[eht16]

Description

In org.opensearch.securityanalytics.indexmanagment/DetectorIndexManagementService there is a log message "info deleteOldIndices" which is more of a trace but it is logged with level error.

In my logs see the following entries (repeated every 12 hours):

Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.a.t.CronTransportAction] [n1-kalgo] Start running AD hourly cron.
Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.a.t.ADTaskManager    ] [n1-kalgo] Start to maintain running historical tasks
Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.a.c.HourlyCron       ] [n1-kalgo] Hourly maintenance succeeds
Dec 17 11:26:39 hostname opensearch[104377]: [ERROR][o.o.s.i.DetectorIndexManagementService] [n1-kalgo] info deleteOldIndices
Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.s.i.DetectorIndexManagementService] [n1-kalgo] No Old Finding Indices to delete
Dec 17 11:26:39 hostname opensearch[104377]: [ERROR][o.o.s.i.DetectorIndexManagementService] [n1-kalgo] info deleteOldIndices
Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.s.i.DetectorIndexManagementService] [n1-kalgo] No Old Alert Indices to delete
Dec 17 11:26:39 hostname opensearch[104377]: [INFO ][o.o.i.i.IndexStateManagementHistory] [n1-kalgo] No Old History Indices to delete

This is fine except the "info deleteOldIndices" which is logged as error but seems like an info or debug message, unless I'm missing anything.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[getsaurabh02]

Thanks @eht16 for taking a stab on it. LGTM.

[codecov-commenter]

Codecov Report

Merging #203 (103d28c) into main (61715cd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #203      +/-   ##
============================================
- Coverage     28.19%   28.19%   -0.01%     
  Complexity      940      940              
============================================
  Files           236      236              
  Lines          9863     9864       +1     
  Branches       1118     1118              
============================================
  Hits           2781     2781              
- Misses         6840     6841       +1     
  Partials        242      242              

Impacted Files	Coverage Δ
...indexmanagment/DetectorIndexManagementService.java	0.00% <0.00%> (ø)

[getsaurabh02]

@eht16 Can we fix the DCO check in the commit

[eht16]

@eht16 Can we fix the DCO check in the commit

@getsaurabh02 done (hopefully correctly).

[eht16]

Anything else missing?

[nkonev]

@getsaurabh02 also bumped into this issue by my monitoring

can you merge this PR ?

[sbcd90]

triggering build

[terryquigleysas]

Hi, could someone confirm whether this change was backported for 2.9.0 or not? If it hasn't been are there plans for it to be in the 2.10.0 release?

[terryquigleysas]

@eht16 Hi, would you be able to confirm whether this change was backported for 2.9.0 or not? If it hasn't been are there plans for it to be in the 2.10.0 release?

Thanks

[eht16]

@terryquigleysas I cannot say for sure if the change is in 2.9.0, I do not see the originally reported log messages anymore.
But now there are messages like:

opensearch[550]: [2023-09-13T12:45:12,860][ERROR][o.o.a.a.AlertIndices     ] [n1-kalgo] info deleteOldIndices

Maybe the log message was moved or so in the meantime.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-203-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e77a7d99d26ee71a4d5377bbf793d7ed16fbaf0e
# Push it to GitHub
git push --set-upstream origin backport/backport-203-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-203-to-2.x.

[opensearch-trigger-bot]

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-203-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e77a7d99d26ee71a4d5377bbf793d7ed16fbaf0e
# Push it to GitHub
git push --set-upstream origin backport/backport-203-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-203-to-2.7.

[opensearch-trigger-bot]

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-203-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e77a7d99d26ee71a4d5377bbf793d7ed16fbaf0e
# Push it to GitHub
git push --set-upstream origin backport/backport-203-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-203-to-2.5.