Add throw for empty strings in rules with modifier contains, startwith, and endswith

[jowg-amazon]

Description

Currently an array out of bounds exception is thrown when a rule tries to be created on an empty string when modifiers contains, startswith and endswith are used. This PR checks for this condition and throws a more descriptive and user friendly error to the front end.

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e3362f6) 24.83% compared to head (b1bf251) 24.84%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
...ityanalytics/rules/objects/SigmaDetectionItem.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #860   +/-   ##
=========================================
  Coverage     24.83%   24.84%           
- Complexity     1030     1035    +5     
=========================================
  Files           277      277           
  Lines         12713    12721    +8     
  Branches       1401     1403    +2     
=========================================
+ Hits           3157     3160    +3     
- Misses         9292     9296    +4     
- Partials        264      265    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[goyamegh]

What will happen to the other values? Should we skip the empty strings and use values which are present in the list?

[jowg-amazon]

We decided to throw an exception instead of skipping the empty string here because if we allowed the rule creation to go through, the empty string would still appear in the rule itself but could not be turned into a meaningful/correct query.

Instead we added additional parsing logic on the front end to ensure that empty strings get parsed out when creating a rule from the UI. This PR is an additional check if the rule gets created from the API directly.

[opensearch-trigger-bot]

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-860-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4ee7bb9118a35ff4706a9e36abb9f2b042c069f
# Push it to GitHub
git push --set-upstream origin backport/backport-860-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport/backport-860-to-2.8.

[opensearch-trigger-bot]

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-860-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4ee7bb9118a35ff4706a9e36abb9f2b042c069f
# Push it to GitHub
git push --set-upstream origin backport/backport-860-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport/backport-860-to-2.6.

[opensearch-trigger-bot]

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-860-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4ee7bb9118a35ff4706a9e36abb9f2b042c069f
# Push it to GitHub
git push --set-upstream origin backport/backport-860-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-860-to-2.10.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-860-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4ee7bb9118a35ff4706a9e36abb9f2b042c069f
# Push it to GitHub
git push --set-upstream origin backport/backport-860-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-860-to-2.x.