STOR-1757: add enhancement for Azure File cloning with azcopy #1542
Conversation
|
@RomanBednar: This pull request references STOR-1499 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane I've added you as a reviewer but feel free to propose any other team member. |
RomanBednar
force-pushed
the
azure-storage-azcopy
branch
2 times, most recently
from
939169a
to
0d310c4
Compare
|
@RomanBednar: This pull request references STOR-1499 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| * According to upstream only samba is supported for cloning, should we support and test only samba or do we want NFS support as well? | ||
| https:/kubernetes-sigs/azurefile-csi-driver/tree/master/deploy/example/cloning#feature-status-beta |
There was a problem hiding this comment.
We must make sure that the driver returns a reasonable error when cloning a NFS volume.
There was a problem hiding this comment.
Ack, moving to goals.
| * Manual testing is performed and passing. | ||
| * End user documentation exists. | ||
|
|
||
| #### Tech Preview -> GA |
There was a problem hiding this comment.
Will we introduce a feature gate for TP? My gut feeling is no, creating a clone of a volume must be explicitly requested by a user.
There was a problem hiding this comment.
Good point, we don't really need the graduation process. However #### Dev Preview -> Tech Preview and #### Tech Preview -> GA headings seem to be enforced by linter. I'll leave them empty and add a new one as a criteria for GA.
There was a problem hiding this comment.
I mean, there should be a note somewhere in the enhancement (not in this section) that we decided not to use a feature gate because XYZ.
There was a problem hiding this comment.
Ok, updating so it's explained right above those two sections.
RomanBednar
force-pushed
the
azure-storage-azcopy
branch
from
0d310c4
to
f6dde85
Compare
RomanBednar
force-pushed
the
azure-storage-azcopy
branch
from
f6dde85
to
b741599
Compare
|
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
RomanBednar
changed the title
cc @openshift/storage