STOR-1499: inital config for azure-storage-azcopy repo #47814
Conversation
openshift-ci
bot
added
the
approved
RomanBednar
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@RomanBednar: This pull request references STOR-1499 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
RomanBednar
force-pushed
the
azcopy-repo-conf
branch
2 times, most recently
from
c03e02c
to
5ba12dd
Compare
RomanBednar
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
RomanBednar
force-pushed
the
azcopy-repo-conf
branch
from
5ba12dd
to
ade54c4
Compare
RomanBednar
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| name: release | ||
| namespace: openshift | ||
| tag: golang-1.19 | ||
| images: |
There was a problem hiding this comment.
images: required for image publishing (postsubmit job): https://docs.ci.openshift.org/docs/how-tos/onboarding-a-new-component/#image-publishing-and-mirroring
| as: | ||
| - registry.ci.openshift.org/ocp/4.16:base | ||
| to: azure-storage-azcopy-base | ||
| promotion: |
There was a problem hiding this comment.
promotion: opt-in for automatic branching: https://docs.ci.openshift.org/docs/architecture/branching/#how-do-i-opt-my-repository-into-automated-branching
|
@RomanBednar: This pull request references STOR-1499 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
RomanBednar
force-pushed
the
azcopy-repo-conf
branch
2 times, most recently
from
aa067ca
to
4ccc13a
Compare
openshift-ci
bot
removed
the
approved
|
/pj-rehearse |
RomanBednar
force-pushed
the
azcopy-repo-conf
branch
2 times, most recently
from
56544d8
to
526e36b
Compare
|
/retest |
| build_root: | ||
| image_stream_tag: | ||
| name: release | ||
| namespace: openshift | ||
| tag: golang-1.19 |
There was a problem hiding this comment.
Go version should be defined in openshift/azure-storage-azcopy repository in .ci-operator.yaml, so ART can change it easily. Here we need:
build_root:
from_repository: true
In addition, I am not sure we support 1.19 go images in 4.16.
There was a problem hiding this comment.
@jsafrane I see, that's better. I followed what we have in efs-utils and we don't use from_repository there. I'm adding ci-operator config to azcopy repo, should be merged first: openshift/azure-storage-azcopy#3
There was a problem hiding this comment.
efs-utils are in python, I'm not sure why we use a go base image there... Maybe because it just works.
RomanBednar
force-pushed
the
azcopy-repo-conf
branch
from
526e36b
to
3755012
Compare
|
/pj-rehearse |
|
/pj-rehearse pull-ci-openshift-azure-storage-azcopy-main-images |
|
/lgtm |
|
/pj-rehearse
|
|
The rehearsal failed now because of the go shim in the builder image which enforces vendor mode, the build of azcopy works fine with Do we need to change the build so it's more similar or same to the way our CI does it? |
|
/pj-rehearse |
|
Current failure is caused by some .gitignore entries causing a few dependencies to be left out from vendor dir, I opened a PR to fix this: openshift/azure-storage-azcopy#5 |
|
/pj-rehearse |
|
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @bparees for approval |
|
@RomanBednar: GitHub didn't allow me to assign the following users: for, approval. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
@RomanBednar: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement: openshift/enhancements#1542
This PR is a prerequisite to requesting ART to manage new content: https://source.redhat.com/groups/public/openshift/openshift_wiki/guidelines_for_requesting_new_content_managed_by_ocp_art
cc @openshift/storage