Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zimit2: iframe on womenshistory.si.edu/events/mysterious-mrs-nixon is not working #364

Closed
benoit74 opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working upstream

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Jul 24, 2024

See openzim/zim-requests#1121 (comment)

First problem is similar to #293, i.e. we need to set isSW: false.

However, this is not sufficient, once set to false we have a weird result:

image

WARC is working OK on replayweb.page

Marking the bug as upstream because to me this looks like a wabac.js wombat issue, I will open one right away.

@benoit74
Copy link
Collaborator Author

Edit: a wombat issue, sorry

Upstream issue is here: webrecorder/wombat#164

@benoit74 benoit74 modified the milestones: 2.1.0, 2.2.0 Aug 5, 2024
@benoit74
Copy link
Collaborator Author

I don't achieve to get a hold on the reason behind it, but this is now working OK. Even with "old" wombat versions and same WARC which cause the issue ... something else fixed the thing probably ...
Sorry for that, but at least no work needed!

@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
@benoit74 benoit74 removed this from the 2.2.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

1 participant