Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame is not working in non-Service worker mode #164

Closed
benoit74 opened this issue Jul 24, 2024 · 2 comments
Closed

iFrame is not working in non-Service worker mode #164

benoit74 opened this issue Jul 24, 2024 · 2 comments

Comments

@benoit74
Copy link

This issue is closely related to #158, but still a bit different so I'm opening a distinct one.

Problem occurs in warc2zim where we use wombat to replay inside the ZIM.

Page where the problem occur is https://womenshistory.si.edu/events/mysterious-mrs-nixon

Test WARC and ZIM with only this page can be found at https://tmp.kiwix.org/ci/test-warc/women-history/

Problem was first that the iframe was not rendered at all first (because we inadequately set the isSw: true in wombat setup. This is known that we need to set it to isSw: false for warc2zim 2.

Despite setting it to isSw: false (which is the case in test ZIM), we now have a weird iframe content. WARC is working on replayweb.page, so this is clearly not a crawling issue.

image

I need help to investigate/fix this issue.

Warc2zim issue is openzim/warc2zim#364

@benoit74
Copy link
Author

I don't achieve to get a hold on the reason behind it, but this is now working OK. Even with "old" wombat versions and same WARC which cause the issue ... something else fixed the thing probably ...
Sorry for that, but at least no work needed!

@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
@ikreymer
Copy link
Member

Glad that it's working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants