Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nice overlay on banner #279

Closed
benoit74 opened this issue Jul 23, 2024 · 4 comments · Fixed by #280
Closed

Add nice overlay on banner #279

benoit74 opened this issue Jul 23, 2024 · 4 comments · Fixed by #280
Assignees
Milestone

Comments

@benoit74
Copy link
Collaborator

When no banner image is used, only a single color is used. When color is white or close to white, it makes a weird gradient.

image

In some old browsers, the gradient does not even load.

It would be nice to have some kind of overlay pattern to make the banner visible in all situations and limit the "weirdness" of this part of the UI under all circumstances.

@benoit74 benoit74 added this to the 3.0.0 milestone Jul 23, 2024
@dan-niles
Copy link
Collaborator

I tried a couple of backgrounds from https://www.magicpattern.design/tools/css-backgrounds. I like the first one. @Popolechien @benoit74 WDYT?

Wavy:
image

Zigzag 3D:
image

Isometric:
image

Polka:
image

@benoit74
Copy link
Collaborator Author

How do they work with "white on white" (which is the main concern as far as I've understood).

For now, my preference order is : isometric > zigzag > wavy > polka ; polka is not visible enough ; wavy is a bit too weird, difficult to know it is an intended pattern or a display bug

@dan-niles
Copy link
Collaborator

Wavy:
image

Zigzag 3D:
image

Isometric:
image

Polka:
image

@benoit74
Copy link
Collaborator Author

What we've agreed in our daily meeting is that we will go with zigzag for now. Could always easily be revisited if someone has strong arguments for something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants