Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an overlay image for the channel banner #280

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

dan-niles
Copy link
Collaborator

Add an overlay image for the channel banner. As discussed in #279 I added the "ZigZag" pattern overlay.

image

Tested on Chrome 60, Firefox 54 and Safari 10.1
Close #279

@dan-niles dan-niles self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.54%. Comparing base (3e161d0) to head (1b32ee3).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #280   +/-   ##
=====================================
  Coverage   1.54%   1.54%           
=====================================
  Files         11      11           
  Lines       1102    1102           
  Branches     162     162           
=====================================
  Hits          17      17           
  Misses      1085    1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review July 25, 2024 14:00
@dan-niles dan-niles requested a review from benoit74 July 25, 2024 14:00
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just rewrote the commit to add a CHANGELOG entry so that I can merge (and most probably release) right away

@benoit74 benoit74 merged commit 665183f into main Jul 29, 2024
10 checks passed
@benoit74 benoit74 deleted the add-banner-overlay branch July 29, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nice overlay on banner
2 participants