Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate DVL to payload section #230

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Relocate DVL to payload section #230

merged 3 commits into from
Aug 18, 2022

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Jul 18, 2022

Precisely what the title says. Follow-up after #213.

@hidmic hidmic requested a review from arjo129 July 18, 2022 19:00
@hidmic hidmic mentioned this pull request Jul 27, 2022
22 tasks
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Collaborator Author

hidmic commented Aug 17, 2022

@arjo129 PTAL, there were a few details lurking below the surface.

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Collaborator Author

hidmic commented Aug 18, 2022

Alright, our frame conventions are a bit of a mess.I'm going for minimal changes. We can rework them in the future.

@hidmic
Copy link
Collaborator Author

hidmic commented Aug 18, 2022

Yay, finally. Going in, in the interest of time.

@hidmic hidmic merged commit ee88635 into main Aug 18, 2022
@hidmic hidmic deleted the hidmic/relocate-dvl branch August 18, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants