Ignition to Gazebo migration #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2022 17:33
Signed-off-by: Marco A. Gutierrez <[email protected]>
Closed
Signed-off-by: Marco A. Gutierrez <[email protected]>
hidmic
reviewed
Aug 29, 2022
There was a problem hiding this comment.
@marcoag I see a few places that still talk about ignition:
./README.md
./docker/empty_world/Dockerfile
./docker/tests/Dockerfile
./docker/base/Dockerfile
./docker/debug_integration/Dockerfile
./lrauv_system_tests/src/LRAUVController.cc
./lrauv_system_tests/worlds/buoyant_tethys_at_depth.sdf
./lrauv_system_tests/worlds/buoyant_tethys.sdf
./lrauv_description/models/tethys_equipped/model.sdf
added 2 commits
August 31, 2022 12:03
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
|
Thanks for the check!
This one is left for the last update as shown in #234. These will also come in later update as part of the mbari side update, see #234.
This one has a line here that might depend on docker changes, so I left it until docker changes are done. Updated these and some extra ones I found on the way. |
hidmic
reviewed
Sep 2, 2022
added 3 commits
September 5, 2022 03:26
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
hidmic
approved these changes
Sep 8, 2022
Co-authored-by: Michel Hidalgo <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #234.
Modifications needed for the Ignition to Gazebo name changing migration.
Signed-off-by: Marco A. Gutierrez [email protected]