Use upstream sensor infrastructure #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the science sensor system plugin and tries to use the upstream plugin. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
…sensor_integration Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
…integration Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
…rf/lrauv into arjo/feat/upstream_sensor_integration Signed-off-by: Arjo Chakravarty <[email protected]>
…sensor_integration
Signed-off-by: Arjo Chakravarty <[email protected]>
There are already tests upstream that do the same thing. With the new API changes I'd have to rewrite the test. Signed-off-by: Arjo Chakravarty <[email protected]>
|
Test failures seem unrelated. |
arjo129
changed the title
hidmic
reviewed
Dec 1, 2022
There was a problem hiding this comment.
Looks reasonable to me, once we've sorted out gazebosim/gz-sim#1814
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
|
There are issues with using the ECM for loading stuff via GUI. The current system works and given the limited time we have, I think we should not risk breaking things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to migrate our code to use the upstream sensors code.
Depends on: