[caguero] Add pinger plugin to wamv_pinger.xacro #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
|
I'm seeing output now, but the range is around 42 rather than 29. Is that OK? |
M1chaelM
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
As mentioned in the other comment, this gives me a range of around 42 rather than 29 (which is what is listed in the testing instructions). However, after moving the pinger to the origin, I was able to verify that I get a range of around 524, which makes sense for the wam-v's coordinates of about -486, 197.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #526 , the pinger plugin wasn't working. This pull request adds the plugin to the xacro macro.
For testing, follow the instructions detailed in #531 .