Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Garden] Fix issue #563 and inertias #566

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Jan 4, 2023

Fix issue #563.

The problem was in the wamv_pinger.xacro. We were creating a visual with an offset equals to the position of the pinger in world coordinates. This is wrong as the visual (if any) should represent the acoustic sensor and it should be inside the wam-v.

I removed the visual and its collision as it's not very useful.

Bonus: I added some missing inertias, otherwise the default inertia values were incorrect. The inertias look good now:

Screenshot from 2023-01-04 17-20-04

How to test it?

  • Recheck the instructions described in [Garden] Port AcousticPinger plugin #531 to confirm that the pinger is still working correctly.
  • Click on the WAM-V. Verify that the bounding box is now correct.
  • Right click and select View->Inertia to confirm that the inertias are reasonable. Note that the inertia visualization is very slow the first time that you request it. This is a Gazebo issue.

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from M1chaelM January 4, 2023 16:29
@caguero caguero changed the title Fix issue #563 and inertias [Garden] Fix issue #563 and inertias Jan 4, 2023
Copy link
Collaborator

@M1chaelM M1chaelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The bounding box looks good.
  • Inertia looks good (and makes a big difference in the behavior of the wam-v!).
  • The pinger appears to still be working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants