pull: Update key loading function to match error style #2058
Conversation
This code wasn't written with idiomatic GError usage; it's not standard to construct an error up front and continually append to its message. The exit from a function is usually `return TRUE`, with error conditions before that. Updating it to match style reveals what I think is a bug; we were silently ignoring failure to parse key files.
|
/lgtm |
|
@d4s: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@d4s: GitHub didn't allow me to request PR reviews from the following users: cgwalters. Note that only ostreedev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hm, right. Are you willing to sign up to do some ongoing code review in general? I am happy to invite you to the organization. |
Thank you! I'll be happy to became a part of the team. |
|
@d4s want to retry a |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, d4s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This code wasn't written with idiomatic GError usage; it's not standard
to construct an error up front and continually append to its
message. The exit from a function is usually
return TRUE,with error conditions before that.
Updating it to match style reveals what I think is a bug;
we were silently ignoring failure to parse key files.