Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull: Update key loading function to match error style #2058

Merged
merged 1 commit into from
Apr 7, 2020
Merged

pull: Update key loading function to match error style #2058

merged 1 commit into from
Apr 7, 2020

Commits on Apr 5, 2020

  1. pull: Update key loading function to match error style 

    This code wasn't written with idiomatic GError usage; it's not standard
to construct an error up front and continually append to its
message.  The exit from a function is usually `return TRUE`,
with error conditions before that.

Updating it to match style reveals what I think is a bug;
we were silently ignoring failure to parse key files.
    @cgwalters
    cgwalters committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    4753987 View commit details
    Browse the repository at this point in the history