Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if a file handle is already in the list return it #1274

Merged
merged 1 commit into from
Mar 8, 2023
Merged

if a file handle is already in the list return it #1274

merged 1 commit into from
Mar 8, 2023

Conversation

cracyc
Copy link
Contributor

@cracyc cracyc commented Mar 6, 2023

fixes #1273

@cracyc cracyc marked this pull request as ready for review March 6, 2023 00:59
@otya128
Copy link
Owner

otya128 commented Mar 8, 2023

Is this a fix for the regression introduced by #1189?

@cracyc
Copy link
Contributor Author

cracyc commented Mar 8, 2023

Yes. Civ2 opens the file the reopens it as an mmiofile with out closing it first so 2 dos handles refer to the same win32 file handle.

@otya128 otya128 merged commit ab35a1d into otya128:master Mar 8, 2023
@cracyc cracyc deleted the file branch March 9, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Civilization II v.2.42 not displaying dialog boxes properly in a new game with empty window running by side
2 participants
@cracyc @otya128