Return Volume's own regions when soft-deleting #6555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly populate the "regions" field in the section of the DecreaseCrucibleResourceCountAndSoftDeleteVolume CTE that constructs the V3 version of the CrucibleResources object. Previously this would almost never return the Volume's regions, causing those to be picked up later by `find_deleted_volume_regions` and cleaned up there. This bug did not result in any leaked regions that this author knows about, but did cause a lot of confusion when examining another unrelated issue.
smklein
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly populate the "regions" field in the section of the DecreaseCrucibleResourceCountAndSoftDeleteVolume CTE that constructs the V3 version of the CrucibleResources object. Previously this would almost never return the Volume's regions, causing those to be picked up later by
find_deleted_volume_regionsand cleaned up there.This bug did not result in any leaked regions that this author knows about, but did cause a lot of confusion when examining another unrelated issue.