Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Volume's own regions when soft-deleting #6555

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Return Volume's own regions when soft-deleting #6555

merged 2 commits into from
Sep 13, 2024

Commits on Sep 12, 2024

  1. Return Volume's own regions when soft-deleting 

    Correctly populate the "regions" field in the section of the
DecreaseCrucibleResourceCountAndSoftDeleteVolume CTE that constructs the
V3 version of the CrucibleResources object. Previously this would almost
never return the Volume's regions, causing those to be picked up later
by `find_deleted_volume_regions` and cleaned up there.

This bug did not result in any leaked regions that this author knows
about, but did cause a lot of confusion when examining another unrelated
issue.
    @jmpesp
    jmpesp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7253a7d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into return_own_regions_when_soft_deleting_volume

    @jmpesp
    jmpesp committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    95b01e5 View commit details
    Browse the repository at this point in the history