-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No output due to EINVAL on Windows #503
Labels
bug
Indicates an unexpected problem or unintended behavior
Comments
Released this now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for reporting a bug! We appreciate it very much. Issues are a big input into the priorities for Pact development
All italic text in this template is safe to remove before submitting
Thanks again!
Software versions
Please provide at least OS and version of pact-js
Issue Checklist
Please confirm the following:
I have set my log level to debug and attached a log file showing the complete request/response cycleFor bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problemExpected behaviour
There is output on Windows.
Actual behaviour
There is no output on Windows.
Steps to reproduce
Have pact-js-core installed either locally or globally and run any command. There is no output, but calling the .bat files directly works fine. Debugging reveals that the child process spawn fails, with EINVAL. As described here Node no longer allows calling of .bat and .cmd files for security reasons. As the input to child process spawn in this project always is sanitized, the fix described in the mentioned Node CVE Report can be safely used to fix this.
Relevant log files
The text was updated successfully, but these errors were encountered: