fix: node doesn't run .bat files on windows

[timvahlbrock]

PR Template

Fixes #503

[timvahlbrock]

@mefellows wasn't able to test this so far, as I didn't have the time to set up the project completely.

[timvahlbrock]

Problem was that I don't have the binary SDK so I didn't have access to the original .bat files. However, I just tested it by creating a dummy .bat file manually and everything works as expected.

[mefellows]

Thanks @timvahlbrock

Problem was that I don't have the binary SDK

What do you mean by this - the standalone tools aren't there? The developer guide has some steps on setting this up for your local.

[mefellows]

Looks like lint failure. Can you please run npm run format:fix and then commit/rebase your changes?

[timvahlbrock]

Thanks @timvahlbrock

Problem was that I don't have the binary SDK

What do you mean by this - the standalone tools aren't there? The developer guide has some steps on setting this up for your local.

Yeah got some errors on npm install relating to Node-Gyp, so I assumed I needed the Native SDK to get the .bat files, which makes little sense in hindsight. Didn't spot the DEVELOPER.md file though (maybe add this to the Contributing section of the README?), but tried to run npm run download-libs script. This failed because windows assumes bash means the bash in my WSL, same problem occurs with the Instructions in the DEVELOPER.md . Just used the Git Bash Terminal in VSCode to run the prebuild script. Another possibility would be to explicitly specify the path to the git bash. The .bat files are now there; I reverified that the changes work as intended.

Will fix the prettier errors in a minute.

[timvahlbrock]

should be good.

[mefellows]

Thanks, yes the development environment is probably not super Windows friendly. Sorry about that.

If the build passes, I'll get this merged and released ASAP.