Skip to content

Commit

Permalink
Fix documentation about justification and finalized == true require…
Browse files Browse the repository at this point in the history
…ment (#1607)

I was reading source code and noticed these two places that are no
longer true after #1211
  • Loading branch information
nazar-pc authored Sep 25, 2023
1 parent b5fcdff commit c0a4ce1
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions substrate/client/service/src/client/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,7 @@ where
CallExecutor::runtime_version(&self.executor, hash)
}

/// Apply a checked and validated block to an operation. If a justification is provided
/// then `finalized` *must* be true.
/// Apply a checked and validated block to an operation.
fn apply_block(
&self,
operation: &mut ClientImportOperation<Block, B>,
Expand Down Expand Up @@ -1766,8 +1765,7 @@ where
{
type Error = ConsensusError;

/// Import a checked and validated block. If a justification is provided in
/// `BlockImportParams` then `finalized` *must* be true.
/// Import a checked and validated block.
///
/// NOTE: only use this implementation when there are NO consensus-level BlockImport
/// objects. Otherwise, importing blocks directly into the client would be bypassing
Expand Down

0 comments on commit c0a4ce1

Please sign in to comment.