Allow justifications on non-finalized blocks #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Aug 30, 2023
This was referenced Sep 1, 2023
|
Friendly ping here |
arkpar
approved these changes
Sep 12, 2023
kayabaNerve
added a commit
to serai-dex/polkadot-sdk
that referenced
this pull request
Oct 17, 2023
This reverts commit ee6eeb7. Serai does define finalized blocks as one with justifications, so we benefit from these asserts.
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
One assertion was unnecessary because of the check right above it, second assertion resolves paritytech#1159 --------- Co-authored-by: Bastian Köcher <[email protected]>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…ment (paritytech#1607) I was reading source code and noticed these two places that are no longer true after paritytech#1211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One assertion was unnecessary because of the check right above it, second assertion resolves #1159