Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: webkitdirectory attribute no longer supported #2631

Closed
camelpunch opened this issue May 15, 2023 · 1 comment · Fixed by #2634
Closed

Regression: webkitdirectory attribute no longer supported #2631

camelpunch opened this issue May 15, 2023 · 1 comment · Fixed by #2634

Comments

@camelpunch
Copy link
Contributor

Environment

  • Elixir version (elixir -v): 1.14.3
  • Phoenix version (mix deps): 1.7.2
  • Phoenix LiveView version (mix deps): 19b7784
  • Operating system: Linux
  • Browsers you attempted to reproduce this bug on (the more the merrier): none
  • Does the problem persist after removing "assets/node_modules" and trying again? Yes/no: no

This commit appears to remove support for the webkitdirectory attribute on live_file_inputs.

Actual behavior

In my app that uses webkitdirectory, I get this warning:

warning: undefined attribute "webkitdirectory" for component Phoenix.Component.live_file_input/1

Expected behavior

No warning. The prior commit does not emit the warning.
@camelpunch camelpunch mentioned this issue May 15, 2023
Merged
@josevalim
Copy link
Member

We should probably list webkitdirectory as an additional :global option. Can you please send a PR?

camelpunch added a commit to camelpunch/phoenix_live_view that referenced this issue May 16, 2023
@camelpunch
Specific webkitdirectory attr for live_file_input
9ee31c6 
Support previously introduced in phoenixframework#1781
Regressed in phoenixframework#2631

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
camelpunch added a commit to camelpunch/phoenix_live_view that referenced this issue May 16, 2023
@camelpunch
Specific webkitdirectory attr for live_file_input
bd14f27 
Support previously introduced in phoenixframework#1781
Regressed in phoenixframework#2631

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
@camelpunch camelpunch mentioned this issue May 16, 2023
Merged
camelpunch added a commit to camelpunch/phoenix_live_view that referenced this issue May 16, 2023
@camelpunch
Permit webkitdirectory attr for live_file_input
05c4221 
Support previously introduced in phoenixframework#1781
Regressed in phoenixframework#2631

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
josevalim pushed a commit that referenced this issue May 16, 2023
@camelpunch
Permit webkitdirectory attr for live_file_input (#2634)
7db0072 
Support previously introduced in #1781
Regressed in #2631

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specific webkitdirectory attr for live_file_input camelpunch/phoenix_live_view
2 participants
@josevalim @camelpunch