Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_input/4 can set an entry's relative path #2632

Merged

Conversation

camelpunch
Copy link
Contributor

Fixes #2628

Allow the file_input test helper to set an upload entry's relative path. This is normally set by browsers when using the webkitdirectory attribute on a file input, in order to upload an entire directory in one go.

Note that while testing this PR on main, I found a regression that removes support for the webkitdirectory attribute in production code.

@chrismccord chrismccord merged commit 69a1a04 into phoenixframework:main May 16, 2023
@chrismccord
Copy link
Member

❤️❤️❤️🐥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveViewTest.file_input/4 doesn't allow setting of newer attributes
2 participants