Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade phylotree.js and fix node renaming #312

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Nov 20, 2023

This PR upgrades all the NPM packages, which results in phylotree.js being upgraded to phylotree.js v1.4.1, which includes two changes we requested. This PR will also fix the issues related to that change in Klados. We also remove the escaping code I added previously since phylotree.js fixed this in PR veg/phylotree.js#448.

Closes #197. Closes #200.

@gaurav gaurav marked this pull request as ready for review February 14, 2024 03:27
@gaurav gaurav requested a review from hlapp February 14, 2024 03:27
@gaurav gaurav requested review from hlapp and removed request for hlapp March 2, 2024 03:07
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gaurav gaurav merged commit e0b9c07 into master Mar 17, 2024
@gaurav gaurav deleted the upgrade-phylotree branch March 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants