Bug in escaping single quotes in Newick export #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2024
stevenweaver
approved these changes
Jan 17, 2024
|
Released in 2.0.1. |
gaurav
added a commit
to phyloref/klados
that referenced
this pull request
Mar 17, 2024
This PR upgrades all the NPM packages, which results in phylotree.js being upgraded to [phylotree.js v1.4.1](https:/veg/phylotree.js/releases/tag/v1.4.1), which includes two changes we requested. This PR will also fix the issues related to that change in Klados. We also remove the escaping code I added previously since phylotree.js fixed this in PR veg/phylotree.js#448. Closes #197. Closes #200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a dumb mistake in my previous PR (#441) where I used
replace()instead ofreplaceAll(), so that only the first single quote was being escaped.This PR fixes that, as well as making a few other minor fixes:
!=with!==.Closes #450.