Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with UDPMuxDefault and NAT1To1IPs #550

Merged
merged 1 commit into from
Apr 14, 2023

Commits on Apr 14, 2023

  1. Fix regression with UDPMuxDefault and NAT1To1IPs

    PR pion#496 added a mechanism to close connections of duplicate candidates
    and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used
    together, candidates may share the same connection, and candidates may
    be equal, since their IPs are overridden by the one specified in
    NAT1To1IPs. When a duplicate candidate is found, its connection is
    closed, making impossible to use any other candidate that shares the
    same connection.
    
    This PR fixes the issue as it prevents duplicate candidates from
    creating connections and getting their connection closed.
    aler9 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    ce83595 View commit details
    Browse the repository at this point in the history