Fix grammar in translations for N_WHATEVER* strings #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, we probably want this, as yet another step to untangle assumptions that work in english, but not in other languages. Can you squash the last commit into the first one? (If not, we can do it when merging) |
|
I don't know how to squash commits without the GitHub button, so please do that. |
|
Saw on IRC that you were waiting on my feedback @impaktor - this one looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5045
Turns out that the word order was not hard-coded but rather a translation mistake. I still need the genitive case though. German also needs this.
Translators can probably hack it with the current implementation, and the German translator did so, but it's very error-prone.
@impaktor