Improve/fix system map #5123
Merged
Improve/fix system map #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gliese852
force-pushed
the
orbits-and-cargo
branch
5 times, most recently
from
4d3e616
to
9c1f02a
Compare
Web-eWorks
reviewed
Jan 21, 2021
|
I have tested this version for an hour - i'd say FIX CONFIRMED |
- add a "static" orbit for bodies that are not moving anywhere - now bodies in a rotating frame and also in the spaceport frame have such "static" orbits - add display of the orbits of objects moving strictly to the star or from the star - fix compile warning for possibly uninitiated variable in LuaSystemView.cpp - fix an issue where smooth animation sometimes have a hard time catching up with a newly selected object Fixes pioneerspacesim#5062
Gliese852
force-pushed
the
orbits-and-cargo
branch
from
9c1f02a
to
582713c
Compare
|
I assume this can be merged. If not, speak up. If someone/@Gliese852 needs it in master now/soon: speak up. |
Web-eWorks
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaSystemView.cppanimation.mp4
Fixes #5062