Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5406: broken scoop mission #5407

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

azieba
Copy link
Contributor

@azieba azieba commented Oct 16, 2022

Fixes #5406

@azieba azieba changed the title Fix for #5406: broken scoop mission Fix #5406: broken scoop mission Oct 16, 2022
Copy link
Member

@Web-eWorks Web-eWorks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@Web-eWorks Web-eWorks merged commit 9f7681d into pioneerspacesim:master Oct 18, 2022
@impaktor
Copy link
Member

@azieba Thanks for contribution. If you want to be in AUTHORS.txt, let us know what name to put.

@azieba
Copy link
Contributor Author

azieba commented Oct 18, 2022

@azieba Thanks for contribution. If you want to be in AUTHORS.txt, let us know what name to put.

That would be very generous of you to add me to the Authors.txt after committing just 3 characters to the code :)
I do not mind if you use my real name.
BR,
Andrzej Zięba

@impaktor
Copy link
Member

Done.

We sometimes forget to add new contributors, but there's no lower code contribution limit for being in the authors file, anything above 0 lines. (Translations (and comments?) don't count, I think).

That would be very generous of you to add me to the Authors.txt after committing just 3 characters to the code

Perhaps I have an ulterior motive, in getting you to submit more pull requests...

@Web-eWorks Web-eWorks mentioned this pull request Nov 6, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoop missions do not work properly because onCargoDestroyed event is not emitted when cargo is scooped.
3 participants