Labels accessibility for ArrayWidget,SelectWidget,TokenWidget

[folix-01]

Readable labels for #5139

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[netlify]

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	0881397
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/66f5870d0a16c0000895401b

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[mister-roboto]

Roman Kysil your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

[stevepiercy]

@folix-01 did you recently remove the email from your GitHub account that you used when signing the Plone Contributor Agreement? That's what mr-roboto is nagging you about. We can't merge this until that is resolved.

[mauritsvanrees]

@folix-01 Two of the commits have this author:

Author: Roman Kysil <[email protected]>

That may trigger the mr.roboto message.
Or maybe this one as well, which probably happened when you used the GitHub UI to merge the main branch in here:

commit ada8a96f9fcd82c38962f56276eb9e8819c2480d
Merge: 6a8bb1f16 a2d997b3e
Author: Roman <[email protected]>
Date:   Thu Sep 26 11:37:31 2024 +0200

    Merge branch 'main' into 5139

Easiest may be to squash all your commits into one and make sure you have the right email on that one.

[folix-01]

@folix-01 Two of the commits have this author:

Author: Roman Kysil <[email protected]>

That may trigger the mr.roboto message. Or maybe this one as well, which probably happened when you used the GitHub UI to merge the main branch in here:

commit ada8a96f9fcd82c38962f56276eb9e8819c2480d
Merge: 6a8bb1f16 a2d997b3e
Author: Roman <[email protected]>
Date:   Thu Sep 26 11:37:31 2024 +0200

    Merge branch 'main' into 5139

Easiest may be to squash all your commits into one and make sure you have the right email on that one.

Thank, just tried, it works

[JeffersonBledsoe]

Labels now actually have the correct role and the inputs associate the name from the label. Looks good!

We also have the same problem with the file widget (e.g. preview image field) and the checkbox widget (e.g. Exclude from navigation), but we can always open another PR for them if you don't want to include them here

[pnicolli]

Yeah I would merge this one in its current state. Are there issues already for the other ones? @JeffersonBledsoe

[JeffersonBledsoe]

Are there issues already for the other ones? @JeffersonBledsoe

Not yet, they're implied in the linked issue. I'll write explicit issues for them shortly