Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modern Script Editor to SPFx v1.20.0 #5273

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

DevPio
Copy link
Contributor

@DevPio DevPio commented Oct 1, 2024

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Updated SharePoint Framework to version 1.20.0

Node Version

v18.17.1

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@Adam-it
Copy link
Contributor

Adam-it commented Oct 1, 2024

Thank you for opening a PR to our samples repo and helping us upgrade our project 👍
We will try to review this PR ASAP

Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevPio Awesome work 👏
I manged to build and add it to my tenant successfully 👍
script editor webpart brings some good old time 🙂
image

I added some few minor comments we could resolve before merging. Please do give them a double check and we are good to go 🚀

samples/react-script-editor/package.json Outdated Show resolved Hide resolved
samples/react-script-editor/README.md Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft October 6, 2024 23:29
@DevPio DevPio marked this pull request as ready for review October 7, 2024 00:03
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🤩

@Adam-it
Copy link
Contributor

Adam-it commented Oct 7, 2024

Thank you @DevPio for a quick turn around.
This will be 🚢ed shortly 👍

@Adam-it Adam-it merged commit 7742268 into pnp:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants