Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modern Script Editor to SPFx v1.20.0 #5273

Merged
merged 3 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/react-script-editor/.yo-rc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@microsoft/generator-sharepoint": {
"libraryName": "pnp-script-editor",
"version": "1.19.0",
"version": "1.20.0",
"environment": "spo",
"isDomainIsolated": false,
"libraryId": "1425175f-3ed8-44d2-8fc4-dd1497191294",
Expand All @@ -10,7 +10,7 @@
"componentType": "webpart",
"nodeVersion": "16.20.0",
"sdkVersions": {
"@microsoft/teams-js": "2.12.0",
"@microsoft/teams-js": "2.24.0",
"@microsoft/microsoft-graph-client": "3.0.2"
}
}
Expand Down
7 changes: 4 additions & 3 deletions samples/react-script-editor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ In order to make it available to absolutely all sites you need apply the *Deploy

This sample is optimally compatible with the following environment configuration:

![SPFx 1.16.1](https://img.shields.io/badge/SPFx-1.16.1-green.svg)
![Node.js v16 | v14 | v12](https://img.shields.io/badge/Node.js-v16%20%7C%20v14%20%7C%20v12-green.svg)
![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
![Node.js v18 ](https://img.shields.io/badge/Node.js-v18-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
Expand All @@ -173,6 +173,7 @@ This sample is optimally compatible with the following environment configuration
* [Felix Bohnacker](https:/felixbohnackerfelixbohnacker)
* [salascz](https:/salascz)
* [Waldek Mastykarz](https:/waldekmastykarz)
* [Luccas Castro](https:/devpio)

## Version history

Expand Down Expand Up @@ -204,7 +205,7 @@ Version|Date|Comments
1.0.23.0|September 7, 2023|Upgrade to SPFx 1.17.4
1.0.24.0|March 8, 2024|Upgrade to SPFx 1.18.2
1.0.25.0|September 25, 2024|Upgrade to SPFx 1.19.0, added support for audience targeting using SharePoint Groups, Entra Groups and individuals.

1.0.26.0|October 1, 2024|Upgrade to SPFx 1.20.0

## Minimal Path to Awesome

Expand Down
14 changes: 7 additions & 7 deletions samples/react-script-editor/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"Coming from old classic SharePoint pages you might have existing script solutions you want to re-use on a modern page without having to repackage it as a new SharePoint Framework web part."
],
"creationDateTime": "2019-10-13",
"updateDateTime": "2023-04-24",
"updateDateTime": "2024-10-01",
"products": [
"SharePoint"
],
Expand All @@ -20,7 +20,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.16.1"
"value": "1.20.0"
},
{
"key": "SPFX-FULLPAGEAPP",
Expand Down Expand Up @@ -64,10 +64,10 @@
"pictureUrl": "https:/salascz.png"
},
{
"gitHubAccount": "wobba",
"name": "Mikael Svenson",
"pictureUrl": "https:/wobba.png"
}
"gitHubAccount": "wobba",
"name": "Mikael Svenson",
"pictureUrl": "https:/wobba.png"
}
],
"references": [
{
Expand All @@ -87,4 +87,4 @@
}
]
}
]
]
4 changes: 2 additions & 2 deletions samples/react-script-editor/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"solution": {
"name": "Modern Script Editor web part by mikaelsvenson",
"id": "1425175f-3ed8-44d2-8fc4-dd1497191294",
"version": "1.0.25.0",
"version": "1.0.26.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": false,
"isDomainIsolated": false,
Expand All @@ -30,7 +30,7 @@
"title": "PnP Modern Script Editor Web Part Feature",
"description": "The feature that activates ScriptEditorWebPart from the pnp-script-editor solution.",
"id": "3a328f0a-99c4-4b28-95ab-fe0847f657a3",
"version": "1.0.25.0",
"version": "1.0.26.0",
"componentIds": [
"3a328f0a-99c4-4b28-95ab-fe0847f657a3"
]
Expand Down
Loading
Loading