🐛 Fix mutations in namespaced modules

Closes #72

Signed-off-by: Eduardo San Martin Morote <[email protected]>

src/index.js

@@ -19,6 +19,8 @@ Object.keys(types).forEach(key => {
  }
 })
 
+const commitOptions = { root: true }
+
 function bindAsObject ({
  key,
  source,
@@ -32,7 +34,7 @@ function bindAsObject ({
  key,
  record: createRecord(snapshot),
  state,
- })
+ }, commitOptions)
  }, cancelCallback)
 
  // return the listeners that have been setup
@@ -51,7 +53,7 @@ function bindAsArray ({
  type: types.VUEXFIRE_ARRAY_INITIALIZE,
  state,
  key,
- })
+ }, commitOptions)
  const onAdd = source.on('child_added', function (snapshot, prevKey) {
  const array = state[key]
  const index = prevKey ? indexForKey(array, prevKey) + 1 : 0
@@ -61,7 +63,7 @@ function bindAsArray ({
  key,
  index,
  record: createRecord(snapshot),
- })
+ }, commitOptions)
  }, cancelCallback)
 
  const onRemove = source.on('child_removed', function (snapshot) {
@@ -72,7 +74,7 @@ function bindAsArray ({
  state,
  key,
  index,
- })
+ }, commitOptions)
  }, cancelCallback)
 
  const onChange = source.on('child_changed', function (snapshot) {
@@ -84,7 +86,7 @@ function bindAsArray ({
  key,
  index,
  record: createRecord(snapshot),
- })
+ }, commitOptions)
  }, cancelCallback)
 
  const onMove = source.on('child_moved', function (snapshot, prevKey) {
@@ -100,7 +102,7 @@ function bindAsArray ({
  index,
  newIndex,
  record: createRecord(snapshot),
- })
+ }, commitOptions)
  }, cancelCallback)
 
  // return the listeners that have been setup

test/modules.spec.js

@@ -14,29 +14,37 @@ test.before(t => {
  Vue.use(Vuex)
 })
 
+const itemsActions = {
+ setItemsRef: firebaseAction(({ bindFirebaseRef }, ref) => {
+ bindFirebaseRef('items', ref)
+ }),
+ unbindItemsRef: firebaseAction(({ unbindFirebaseRef }) => {
+ unbindFirebaseRef('items')
+ }),
+}
+
 test.beforeEach(t => {
  t.context.store = new Vuex.Store({
+ mutations: firebaseMutations,
  modules: {
+ named: {
+ namespaced: true,
+ state: { items: [] },
+ actions: itemsActions,
+ },
  todos: {
  state: {
  items: [],
  options: null,
  },
- actions: {
- setItemsRef: firebaseAction(({ bindFirebaseRef }, ref) => {
- bindFirebaseRef('items', ref)
- }),
+ actions: Object.assign({
  setOptionsRef: firebaseAction(({ bindFirebaseRef }, ref) => {
  bindFirebaseRef('options', ref)
  }),
- unbindItemsRef: firebaseAction(({ unbindFirebaseRef }) => {
- unbindFirebaseRef('items')
- }),
  unbindOptionsRef: firebaseAction(({ unbindFirebaseRef }) => {
  unbindFirebaseRef('options')
  }),
- },
- mutations: firebaseMutations,
+ }, itemsActions),
  },
  },
  })
@@ -65,3 +73,22 @@ test('binds an array to a module', t => {
  t.context.ref.flush()
  t.deepEqual(t.context.store.state.todos.items[0].index, 3)
 })
+
+test('works on namespaced modules', t => {
+ t.context.store.dispatch('named/setItemsRef', t.context.ref)
+ t.context.ref.set({
+ first: { index: 0 },
+ second: { index: 1 },
+ third: { index: 2 },
+ })
+ t.context.ref.flush()
+
+ t.deepEqual(t.context.store.state.named.items, [
+ { '.key': 'first', index: 0 },
+ { '.key': 'second', index: 1 },
+ { '.key': 'third', index: 2 },
+ ])
+ t.context.ref.child('first').child('index').set(3)
+ t.context.ref.flush()
+ t.deepEqual(t.context.store.state.named.items[0].index, 3)
+})