Skip to content
This repository has been archived by the owner on Apr 19, 2019. It is now read-only.

Update README.md: Mutations in namespaced modules. #72

Closed
wants to merge 1 commit into from

Conversation

frandiox
Copy link

Hi! Thanks a lot for the repo. Looks like it is actually necessary to add firebaseMutations to namespaced modules. Otherwise, it throws [vuex] unknown local mutation type: VUEXFIRE_ARRAY_INITIALIZE, global type: db/VUEXFIRE_ARRAY_INITIALIZE or similar.
I'm just adding a small notice here but feel free to close it if you want to explain it better with an example or anything.

Thanks!

@codecov-io
Copy link

codecov-io commented May 14, 2017

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         105    105           
=====================================
  Hits          105    105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98afc75...4128f29. Read the comment docs.

@posva posva closed this in 844e080 May 14, 2017
@posva
Copy link
Owner

posva commented May 14, 2017

Hey, thanks for the contribution, it was actually a bug so I fixed it instead. I'll release a new version in a second 🙂

@frandiox
Copy link
Author

@posva Even better then, thanks :)

@frandiox frandiox deleted the patch-1 branch May 15, 2017 03:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants