Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix for currency spec #2889

Merged
merged 23 commits into from
Jan 15, 2024
Merged

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Jan 8, 2024

This PR aim to resolve this issue:

Error:  Failures: 
Error:    CurrencySpec.PBS should return currency rates:38 Condition not satisfied:
response.rates?.size() > 0
|        |      |      |
|        null   null   false
org.prebid.server.functional.model.response.currencyrates.CurrencyRatesResponse(active:true, source:http://tc-9DxGcinQ:1080/currency, fetchingIntervalNs:900000000000)

@marki1an marki1an added work in progress Signals not finished work tests Functional or other tests do not merge Not the time for merging yet labels Jan 8, 2024
@marki1an marki1an removed do not merge Not the time for merging yet work in progress Signals not finished work labels Jan 13, 2024
@marki1an marki1an changed the title Tests: Fix for mockserver Tests: Fix for CurrencySpec Jan 13, 2024
@marki1an marki1an self-assigned this Jan 13, 2024
@marki1an marki1an changed the title Tests: Fix for CurrencySpec Tests: Fix for currency spec Jan 13, 2024
@SerhiiNahornyi SerhiiNahornyi merged commit 7ba717f into master Jan 15, 2024
2 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the fix-for-currency-mockserver branch January 15, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants