Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix for currency spec #2889

Merged
merged 23 commits into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class CurrencySpec extends BaseSpec {

def "PBS should return currency rates"() {
when: "PBS processes bidders params request"
def response = pbsService.sendCurrencyRatesRequest()
def response = pbsService.withWarmup().sendCurrencyRatesRequest()

then: "Response should contain bidders params"
assert response.rates?.size() > 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class PriceFloorsCurrencySpec extends PriceFloorsBaseSpec {
private static final CurrencyConversion currencyConversion = new CurrencyConversion(networkServiceContainer).tap {
setCurrencyConversionRatesResponse(CurrencyConversionRatesResponse.getDefaultCurrencyConversionRatesResponse(DEFAULT_CURRENCY_RATES))
}
private static final String GENERAL_ERROR_METRIC = "price-floors.general.err"
private static final Map<String, String> CURRENCY_CONVERTER_CONFIG = ["auction.ad-server-currency" : "USD",
"currency-converter.external-rates.enabled" : "true",
"currency-converter.external-rates.url" : "$networkServiceContainer.rootUri/currency".toString(),
Expand All @@ -40,8 +41,6 @@ class PriceFloorsCurrencySpec extends PriceFloorsBaseSpec {
private final PrebidServerService currencyFloorsPbsService = pbsServiceFactory.getService(FLOORS_CONFIG +
CURRENCY_CONVERTER_CONFIG)

private static final String GENERAL_ERROR_METRIC = "price-floors.general.err"

def "PBS should update bidFloor, bidFloorCur for signalling when request.cur is specified"() {
given: "Default BidRequest with cur"
def bidRequest = bidRequestWithFloors.tap {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ abstract class PrivacyBaseSpec extends BaseSpec {
def isVendorListCachedClosure = {
def validConsentString = new TcfConsent.Builder()
.setPurposesLITransparency(BASIC_ADS)
.addVendorLegitimateInterest([GENERIC_VENDOR_ID])
.setVendorLegitimateInterest([GENERIC_VENDOR_ID])
.build()
def bidRequest = getGdprBidRequest(validConsentString)

Expand Down
Loading