fix errors reported by go vet (#2954)

adapters/bidder_test.go

@@ -52,12 +52,12 @@ type mockConversions struct {
  mock.Mock
 }
 
-func (m mockConversions) GetRate(from string, to string) (float64, error) {
+func (m *mockConversions) GetRate(from string, to string) (float64, error) {
  args := m.Called(from, to)
  return args.Get(0).(float64), args.Error(1)
 }
 
-func (m mockConversions) GetRates() *map[string]map[string]float64 {
+func (m *mockConversions) GetRates() *map[string]map[string]float64 {
  args := m.Called()
  return args.Get(0).(*map[string]map[string]float64)
 }

bidadjustment/apply_test.go

@@ -223,12 +223,12 @@ type mockConversions struct {
  mock.Mock
 }
 
-func (m mockConversions) GetRate(from string, to string) (float64, error) {
+func (m *mockConversions) GetRate(from string, to string) (float64, error) {
  args := m.Called(from, to)
  return args.Get(0).(float64), args.Error(1)
 }
 
-func (m mockConversions) GetRates() *map[string]map[string]float64 {
+func (m *mockConversions) GetRates() *map[string]map[string]float64 {
  args := m.Called()
  return args.Get(0).(*map[string]map[string]float64)
 }

endpoints/openrtb2/amp_auction_test.go

@@ -88,7 +88,7 @@ func TestGoodAmpRequests(t *testing.T) {
  continue
  }
 
- test.storedRequest = map[string]json.RawMessage{tagID: test.BidRequest}
+ test.StoredRequest = map[string]json.RawMessage{tagID: test.BidRequest}
  test.endpointType = AMP_ENDPOINT
 
  cfg := &config.Configuration{
@@ -165,7 +165,7 @@ func TestAccountErrors(t *testing.T) {
  if !assert.NoError(t, json.Unmarshal(fileJsonData, &test), "Failed to unmarshal data from file: %s. Error: %v", tt.filename, err) {
  continue
  }
- test.storedRequest = map[string]json.RawMessage{tt.storedReqID: test.BidRequest}
+ test.StoredRequest = map[string]json.RawMessage{tt.storedReqID: test.BidRequest}
  test.endpointType = AMP_ENDPOINT
 
  cfg := &config.Configuration{
@@ -2190,7 +2190,7 @@ func TestValidAmpResponseWhenRequestRejected(t *testing.T) {
  query := request.URL.Query()
  tagID := query.Get("tag_id")
 
- test.storedRequest = map[string]json.RawMessage{tagID: test.BidRequest}
+ test.StoredRequest = map[string]json.RawMessage{tagID: test.BidRequest}
  test.planBuilder = tc.planBuilder
  test.endpointType = AMP_ENDPOINT
 

endpoints/openrtb2/test_utils.go

@@ -76,7 +76,7 @@ type testCase struct {
  ExpectedBidResponse json.RawMessage `json:"expectedBidResponse"`
 
  // "/openrtb2/amp" endpoint JSON test info
- storedRequest map[string]json.RawMessage `json:"mockAmpStoredRequest"`
+ StoredRequest map[string]json.RawMessage `json:"mockAmpStoredRequest"`
  StoredResponse map[string]json.RawMessage `json:"mockAmpStoredResponse"`
  ExpectedAmpResponse json.RawMessage `json:"expectedAmpResponse"`
 }
@@ -1265,8 +1265,8 @@ func buildTestEndpoint(test testCase, cfg *config.Configuration) (httprouter.Han
  testExchange, mockBidServersArray := buildTestExchange(test.Config, adapterMap, mockBidServersArray, mockCurrencyRatesServer, bidderInfos, cfg, met, mockFetcher)
 
  var storedRequestFetcher stored_requests.Fetcher
- if len(test.storedRequest) > 0 {
- storedRequestFetcher = &mockAmpStoredReqFetcher{test.storedRequest}
+ if len(test.StoredRequest) > 0 {
+ storedRequestFetcher = &mockAmpStoredReqFetcher{test.StoredRequest}
  } else {
  storedRequestFetcher = &mockStoredReqFetcher{}
  }

server/server.go

@@ -20,7 +20,7 @@ import (
 
 // Listen blocks forever, serving PBS requests on the given port. This will block forever, until the process is shut down.
 func Listen(cfg *config.Configuration, handler http.Handler, adminHandler http.Handler, metrics *metricsconfig.DetailedMetricsEngine) (err error) {
- stopSignals := make(chan os.Signal)
+ stopSignals := make(chan os.Signal, 1)
  signal.Notify(stopSignals, syscall.SIGTERM, syscall.SIGINT)
 
  // Run the servers. Fan any process-stopper signals out to each server for graceful shutdowns.