Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the
validate.sh
script has been executed as part of the PR checks. However, there was an issue with how thego vet
command was invoked in the script.prebid-server/validate.sh
Lines 59 to 63 in 95c269f
Currently, the
go vet
command is not checking all the files. This resulted to errors/ warnings not being captured during the PR checks.The solution is to modify the command to
go vet ./...
which will ensure that all files are thoroughly checked during the PR checks.The plan here is to update the script to execute the
go vet ./...
command. However, before implementing this change, let's address any previously uncaught errors or warnings. PR makes changes to fix some errors or warnings reported bygo vet