Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Wormbase URI #32

Closed

Conversation

RichardBruskiewich
Copy link

... to reflect the simpler one in Identifiers.org

... to reflect the simpler one in Identifiers.org
Copy link
Collaborator

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately you can't edit here, this has to be edited upstream, this file is derived cc @deepakunni3 @kshefchek

@RichardBruskiewich
Copy link
Author

RichardBruskiewich commented Nov 25, 2020

unfortunately you can't edit here, this has to be edited upstream, this file is derived cc @deepakunni3 @kshefchek

Hi @cmungall, actually .. you'll note in the original issue that I also already issued a PR request to the PrefixCommons biocontext for Monarch at #32 for this change. If @deepakunni3 @kshefchek have commit/merge access to the PrefixCommons repo, then they can process the PR and I can revert this Biolink Model YAML file prefixes section change.

@deepakunni3
Copy link
Collaborator

@kshefchek Would be great to get your feedback on how to handle this change.

@kshefchek
Copy link
Contributor

the workflow for changing the monarch context is requesting a change to this file - https:/monarch-initiative/dipper/blob/master/dipper/curie_map.yaml, and then regenerating the the context ld file here (although I think we've meant to automate this step).

@RichardBruskiewich
Copy link
Author

the workflow for changing the monarch context is requesting a change to this file - https:/monarch-initiative/dipper/blob/master/dipper/curie_map.yaml, and then regenerating the the context ld file here (although I think we've meant to automate this step).

Thanks @kshefchek (cc: @cmungall @deepakunni3), I've created a fresh PR monarch-initiative/dipper#1000.

I'll go ahead and cancel/close every other related issue/PR

@RichardBruskiewich
Copy link
Author

Proposed change kicked over to monarch-initiative/dipper#1000.

Sorry... didn't fully understand the chain of causality here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants