test that on
- and addEventListener
callbacks fire on passthrough
#117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
addEventListener
from firing on passed-through requestsIn the passthrough tests, there are a few places where
pretender._nativeXMLHttpRequest
is changed in order to facilitate testing, but Pretender sets the window'sXMLHttpRequest
tothis._nativeXMLHttpRequest
in#shutdown
. This resulted inwindow.XMLHttpRequest
getting incorrectly permanently changed to the stubtesXHR
method when those tests callpretender.shutdown
inteardown
.FakeXMLHttpRequest's
dispatchEvent
methodmust be called with the event (which must have a
type
key) instead of(eventName, event)
. When called with theeventName
string as the first argument, the fake XHR never locates theaddEventListener
-added listeners and so never calls them. This PR fixes the call todispatchEvent
to have the correct parameter and adds tests that callbacks added using both methods will be called.