Fix wrong invocation of dispatchEvent method for passthrough requests. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This fixes event listeners added via addEventListener() not being called.
simonihmig
changed the title
|
this will need a test |
|
@simonihmig this still relevant? |
|
I think so, the signature for dispatchEvent expects a single argument, the event object, but it is called as I didn't have the time to write a test for getting this merged though, I will try to do it the next days... |
|
Thanks for pointing this out. This was fixed in #117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where event listeners added via addEventListener() to a passthrough request were not being called.